[Feature] Optional notification title #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickstaa
approved these changes
Aug 15, 2023
rickstaa
added a commit
that referenced
this pull request
Aug 15, 2023
* Added optional notification title * refactor: small code improvements --------- Co-authored-by: rickstaa <[email protected]>
|
@TrimVis, thanks a lot for your contribution 🚀. Your pull request has been included in https://github.com/rickstaa/tmux-notify/releases/tag/v1.5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't find any information about merging new features, therefore I hope I'm doing this the correct way :)
I personally prefer my notifications to show the program in the summary and the action/information in the notification body.
This PR adds the
@tnotify-verbose-title, if it is not set the behavior is unchanged to the current one.However if it is set, the summary will be replaced with the corresponding value and the
@tnotify-verbose-msgwill be shifted to the message body.I'm open for suggestions, but I think this is a sensible way to users to set a custom body as well as summary