From 034130c02ffb47b0026059b57d17e9b080976ff3 Mon Sep 17 00:00:00 2001 From: Justin Dhillon Date: Sun, 3 Mar 2024 14:44:27 -0800 Subject: [PATCH] Fix Broken Links In Documentation (#28321) ## Summary I used [link-inspector](https://github.com/justindhillon/link-inspector) to find a bunch of broken links in this projects documentation. Here is what I fixed: https://www.html5rocks.com/en/tutorials/canvas/hidpi/ --> https://web.dev/articles/canvas-hidipi https://w3c.github.io/webcomponents/spec/custom/#custom-elements-core-concepts --> https://www.w3.org/TR/custom-elements/ https://github.com/facebookarchive/fixed-data-table/blob/main/src/vendor_upstream/dom/normalizeWheel.js --> https://github.com/facebookarchive/fixed-data-table/blob/master/src/vendor_upstream/dom/normalizeWheel.js https://upload.wikimedia.org/wikipedia/commons/e/ee/Atom_%282%29.png --> https://upload.wikimedia.org/wikipedia/commons/1/1b/Atom.png ## Support my work I used [link-inspector](https://github.com/justindhillon/link-inspector) to find and fix this issue. If you find this PR useful, give the repo a :star: --- fixtures/dom/src/components/fixtures/suspense/index.js | 2 +- packages/react-devtools-shared/src/devtools/cache.js | 2 +- packages/react-devtools-timeline/src/view-base/Surface.js | 2 +- .../src/view-base/utils/normalizeWheel.js | 2 +- packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js | 2 +- packages/react-dom-bindings/src/shared/isCustomElement.js | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fixtures/dom/src/components/fixtures/suspense/index.js b/fixtures/dom/src/components/fixtures/suspense/index.js index ce4c64f30e8ab..552f9ba23ad1f 100644 --- a/fixtures/dom/src/components/fixtures/suspense/index.js +++ b/fixtures/dom/src/components/fixtures/suspense/index.js @@ -213,7 +213,7 @@ class TextInputFixtures extends React.Component { - + React is cool diff --git a/packages/react-devtools-shared/src/devtools/cache.js b/packages/react-devtools-shared/src/devtools/cache.js index 4bb44bacb3a5b..a11032caf5907 100644 --- a/packages/react-devtools-shared/src/devtools/cache.js +++ b/packages/react-devtools-shared/src/devtools/cache.js @@ -15,7 +15,7 @@ import {createContext} from 'react'; // TODO (cache) Remove this cache; it is outdated and will not work with newer APIs like startTransition. // Cache implementation was forked from the React repo: -// https://github.com/facebook/react/blob/main/packages/react-cache/src/ReactCache.js +// https://github.com/facebook/react/blob/main/packages/react-cache/src/ReactCacheOld.js // // This cache is simpler than react-cache in that: // 1. Individual items don't need to be invalidated. diff --git a/packages/react-devtools-timeline/src/view-base/Surface.js b/packages/react-devtools-timeline/src/view-base/Surface.js index 4708cd95f787a..81c0199cc743d 100644 --- a/packages/react-devtools-timeline/src/view-base/Surface.js +++ b/packages/react-devtools-timeline/src/view-base/Surface.js @@ -21,7 +21,7 @@ export type ViewRefs = { hoveredView: View | null, }; -// hidpi canvas: https://www.html5rocks.com/en/tutorials/canvas/hidpi/ +// hidpi canvas: https://web.dev/articles/canvas-hidipi function configureRetinaCanvas( canvas: HTMLCanvasElement, height: number, diff --git a/packages/react-devtools-timeline/src/view-base/utils/normalizeWheel.js b/packages/react-devtools-timeline/src/view-base/utils/normalizeWheel.js index 9b27792c95dd0..95f3db1aea2dc 100644 --- a/packages/react-devtools-timeline/src/view-base/utils/normalizeWheel.js +++ b/packages/react-devtools-timeline/src/view-base/utils/normalizeWheel.js @@ -7,7 +7,7 @@ * @flow */ -// Adapted from: https://github.com/facebookarchive/fixed-data-table/blob/main/src/vendor_upstream/dom/normalizeWheel.js +// Adapted from: https://github.com/facebookarchive/fixed-data-table/blob/master/src/vendor_upstream/dom/normalizeWheel.js export type NormalizedWheelDelta = { deltaX: number, diff --git a/packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js b/packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js index b3b99db80dec7..0410f9f042211 100644 --- a/packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js +++ b/packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js @@ -3710,7 +3710,7 @@ export function pushStartInstance( return pushSelfClosing(target, props, type); } // These are reserved SVG and MathML elements, that are never custom elements. - // https://w3c.github.io/webcomponents/spec/custom/#custom-elements-core-concepts + // https://html.spec.whatwg.org/multipage/custom-elements.html#custom-elements-core-concepts case 'annotation-xml': case 'color-profile': case 'font-face': diff --git a/packages/react-dom-bindings/src/shared/isCustomElement.js b/packages/react-dom-bindings/src/shared/isCustomElement.js index 39d5d7fe187e0..c546501040743 100644 --- a/packages/react-dom-bindings/src/shared/isCustomElement.js +++ b/packages/react-dom-bindings/src/shared/isCustomElement.js @@ -15,7 +15,7 @@ function isCustomElement(tagName: string, props: Object): boolean { // These are reserved SVG and MathML elements. // We don't mind this list too much because we expect it to never grow. // The alternative is to track the namespace in a few places which is convoluted. - // https://w3c.github.io/webcomponents/spec/custom/#custom-elements-core-concepts + // https://html.spec.whatwg.org/multipage/custom-elements.html#custom-elements-core-concepts case 'annotation-xml': case 'color-profile': case 'font-face':