From 7f6a0bebfa8801abd844f9384c74b59198a6ca9a Mon Sep 17 00:00:00 2001 From: Matthias Kaeppler Date: Mon, 14 Oct 2013 10:22:26 +0200 Subject: [PATCH] Only release references in unsubscribe We decided it's better to leave it to the caller when it's appropriate to release, cf. #1 --- .../rx/operators/OperationObserveFromAndroidComponent.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/rxjava-contrib/rxjava-android/src/main/java/rx/operators/OperationObserveFromAndroidComponent.java b/rxjava-contrib/rxjava-android/src/main/java/rx/operators/OperationObserveFromAndroidComponent.java index 8d945fba516..c19cb1076b0 100644 --- a/rxjava-contrib/rxjava-android/src/main/java/rx/operators/OperationObserveFromAndroidComponent.java +++ b/rxjava-contrib/rxjava-android/src/main/java/rx/operators/OperationObserveFromAndroidComponent.java @@ -79,7 +79,6 @@ public void onCompleted() { observerRef.onCompleted(); } else { log("onComplete: target component released or detached; dropping message"); - releaseReferences(); } } @@ -89,7 +88,6 @@ public void onError(Throwable e) { observerRef.onError(e); } else { log("onError: target component released or detached; dropping message"); - releaseReferences(); } } @@ -99,7 +97,6 @@ public void onNext(T args) { observerRef.onNext(args); } else { log("onNext: target component released or detached; dropping message"); - releaseReferences(); } } });