Fix for pg authentication issue in node 6+ #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- There is a change in `Buffer` in node 6 that causes an issue with authentication in the `pg`/`pg.js` modules. - See brianc/node-postgres#1018 - Which references: brianc/node-postgres#1000 - This commit changes the pg library dependency to the version that contains the fix for this issue.
|
Thanks @andywhite37! I'll have this merged and published shortly |
|
This has been published to npm as version 2.8.1. |
|
Cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bufferin node 6+ that causes an issue withauthentication in the
pg/pg.jsmodules.contains the fix for this issue.
Basically, in node 6+,
postgratoris intermittently failing when trying to run the migrations. I don't know why it's intermittent, and not just an error everytime, but that seems to be what others are seeing.pg.js4.1.1 (the latestpg.jsversion) appears to still have the issue, but usingpg4.5.5 or later appears to fix the issue.