Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The vignettes are no longer being built properly under R v4.2.1 running on Windows when installed via remotes::install_github(). #474

Closed
ScientificProgrammer opened this issue Sep 12, 2022 · 1 comment

Comments

@ScientificProgrammer
Copy link

Previously, I've had no problem building the vignettes for the R DiagrammeR package when installing the development version via remotes::install_github. Now, I'm able to install the development version of the package, but the vignettes aren't being built.

As the following output shows, the ``\library\DiagrammeR\html` subdirectory contains just two files, the main html file and its `css` file. In the past, this directory contained all of the needed `html` files referenced by `00Index.html`.

d:\tmp\R>dir /ogn %RPath%\library\DiagrammeR\html
 Volume in drive C is Windows
 Volume Serial Number is 8C87-394D

 Directory of C:\R\R-4.2.1\library\DiagrammeR\html

09/12/2022  05:28 PM    <DIR>          .
09/12/2022  05:28 PM    <DIR>          ..
09/12/2022  05:28 PM            38,464 00Index.html
09/12/2022  05:28 PM             1,735 R.css
               2 File(s)         40,199 bytes
               2 Dir(s)  148,662,890,496 bytes free
    

Here is the command I'm using to install the package, along with the output.

R version 4.2.1 (2022-06-23 ucrt) -- "Funny-Looking Kid"
Copyright (C) 2022 The R Foundation for Statistical Computing
Platform: x86_64-w64-mingw32/x64 (64-bit)

R is free software and comes with ABSOLUTELY NO WARRANTY.
You are welcome to redistribute it under certain conditions.
Type 'license()' or 'licence()' for distribution details.

R is a collaborative project with many contributors.
Type 'contributors()' for more information and
'citation()' on how to cite R or R packages in publications.

Type 'demo()' for some demos, 'help()' for on-line help, or
'help.start()' for an HTML browser interface to help.
Type 'q()' to quit R.

> remotes::install_github(
+     'rich-iannone/DiagrammeR',
+     force = TRUE,
+     build_vignettes = TRUE,
+     build_manuals = TRUE
+ )

── R CMD build ──────────────────────────────────────────────────────────────────────────────────────────────────────────
✔  checking for file 'C:\Users\eric_\AppData\Local\Temp\RtmpuS6gNX\remotes1d4420d252f6\rich-iannone-DiagrammeR-3b5f18a/DESCRIPTION' ...
─  preparing 'DiagrammeR': (3.6s)
✔  checking DESCRIPTION meta-information ... 
─  checking for LF line-endings in source and make files and shell scripts (1s)
─  checking for empty or unneeded directories
   Removed empty directory 'DiagrammeR/man/figures'
─  building 'DiagrammeR_1.0.9.9000.tar.gz'
   
* installing *source* package 'DiagrammeR' ...
** using staged installation
** R
** data
*** moving datasets to lazyload DB
** inst
** byte-compile and prepare package for lazy loading
** help
*** installing help indices
** building package indices
** testing if installed package can be loaded from temporary location
** testing if installed package can be loaded from final location
** testing if installed package keeps a record of temporary installation path
* DONE (DiagrammeR)

Please let me know if you need any additional information.

@olivroy
Copy link
Collaborator

olivroy commented Nov 8, 2023

The vignettes in DiagrammeR are currently there as articles, which mean they are not checked with R CMD CHECK. i.e. they are ignored during build as they are not stable.

This may change in the near future. See https://r-pkgs.org/vignettes.html#sec-vignettes-how-built for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants