Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 - Padding 0 Issues #629

Open
2 of 9 tasks
saiidhanna21 opened this issue Apr 30, 2024 · 9 comments
Open
2 of 9 tasks

🐞 - Padding 0 Issues #629

saiidhanna21 opened this issue Apr 30, 2024 · 9 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@saiidhanna21
Copy link

Which @codeimage/* package(s) are the source of the bug?

codeimage

Please provide a screenshot or a video to a minimal reproduction of the bug

No response

Description

When padding is set to zero, we lose the radius on the code image. But once we click download it give us the rounded form, however it is cut on corners

Which browsers have you used?

  • Chrome
  • Firefox
  • Safari
  • Edge

Which operating systems have you used?

  • macOS
  • Windows
  • Linux
  • iOS
  • Android
@saiidhanna21 saiidhanna21 added the bug Something isn't working label Apr 30, 2024
@AlLubila
Copy link

AlLubila commented May 5, 2024

I forked the repository to try to fix this bug

@AlLubila
Copy link

AlLubila commented May 5, 2024

@saiidhanna21 I forked the repository to try to fix this bug

@AlLubila
Copy link

AlLubila commented May 5, 2024

@saiidhanna21 In which file can I find the sidebar code ? Thanks

@AlLubila
Copy link

AlLubila commented May 5, 2024

@riccardoperra I see, I will do my best to help you then. I will check each link and see how I can fix it(●'◡'●)

@AlLubila
Copy link

AlLubila commented May 6, 2024

@riccardoperra @saiidhanna21

My summary while I was debugging:

THE PROBLEM
When the padding is set to 0 the terminal loose its border-radius

OBSERVATION IN THE CONSOLE
When the padding is set to 0:
The class .terminal_wrapper is overlapping by the element.style(The highest container div of terminal) where the custom Radius(var--) is set to 0

SOLUTION
Find a way to disable the custom Radius of the element.style(The highest container div of terminal)

BUT, BUT
After writting code to remove the custom radius style in the highest div of terminal you must set the value of radius in the sidebar to 16 to avoid that background behind the terminal be seen.

VIDEO TO ILLUSTRATE WHAT I WROTE ⬇️ I hope it will help you to fix this issue 👌

CodeImage.-.A.tool.to.manage.and.beautify.your.code.screenshots.-.Brave.2024-05-06.15-00-23.1.1.mp4

@riccardoperra
Copy link
Owner

Hey @AlLubila, thanks for your explanation. I can investigate on this this weekend and give you more information on how to handle this.

Currently I think that the image backdrop should change his radius according to what the user choose.

However, if the user has set padding to 0, I think that we should disable the border type option (set to none/null) and the shadows (these could already be hidden since we are using overflow auto

@AlLubila
Copy link

@riccardoperra Got it, If I find a way to contibute again I will share with you

Copy link

stale bot commented Sep 10, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants