Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 - Vue Support #424

Closed
kupoback opened this issue Dec 16, 2022 · 6 comments · Fixed by #429
Closed

🚀 - Vue Support #424

kupoback opened this issue Dec 16, 2022 · 6 comments · Fixed by #429
Labels
feature New feature or request

Comments

@kupoback
Copy link

kupoback commented Dec 16, 2022

Which @codeimage/* package(s) are relevant/releated to the feature request?

Editor Language

Description

Would love it if you could get Vue syntax support. You have the icon for it, but the Language Editor defaults to "Typescript", which isn't always the syntax case for Vue.

@kupoback kupoback added the feature New feature or request label Dec 16, 2022
@riccardoperra
Copy link
Owner

This may take a while since CodeMirror 6 doesn't have vue language as is core, but there is already an integration for cm5

I need to do some investigation in order to understand what's needed to mix languages and add some vue rules to the current parser 😄

@riccardoperra
Copy link
Owner

Hey @kupoback, i'm not a vue user ..is this highlight ok? I tried to add both tsx and html language while using .vue extension

image

@kupoback
Copy link
Author

Hey @kupoback, i'm not a vue user ..is this highlight ok? I tried to add both tsx and html language while using .vue extension

image

Yeah, this looks great! I was going to suggest taking a look at the Examples documentation on Vue to see what could be combined, but using HTML/CSS and TypeScript should be just fine!

https://vuejs.org/examples/#fetching-data

@riccardoperra
Copy link
Owner

Perfect, it seems the same I think 😄
image

I've opened a pr #429 with that demo https://codeimage-app-pr-429.vercel.app/

This will be deployed tomorrow I think

@kupoback
Copy link
Author

Looks good to me! Great work!

@riccardoperra
Copy link
Owner

@kupoback Deployed now with 1.0.9 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants