Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 - Add Vitesse Dark theme #305

Closed
riccardoperra opened this issue Jul 13, 2022 · 5 comments
Closed

🚀 - Add Vitesse Dark theme #305

riccardoperra opened this issue Jul 13, 2022 · 5 comments
Assignees
Labels
feature New feature or request good first issue Good for newcomers hacktoberfest
Milestone

Comments

@riccardoperra
Copy link
Owner

riccardoperra commented Jul 13, 2022

Which @codeimage/* package(s) are relevant/releated to the feature request?

highlight

Description

This task consist of creating a new theme for CodeImage editor using CodeMirror API.

https://github.com/antfu/vscode-theme-vitesse


Instructions for contributions

NOTE If your intention is to only develop a new theme, you don't need to use docker or install everything. You will work only on @codeimage/highlight package

  • Move to packages/highlight. You will see a How to create a new theme section in the README.md file .
  • Run the pnpm generate:theme script and put the vitesse theme name
  • Open the theme playground with pnpm dev (from the highlight package) or pnpm dev --filter=@codeimage/highlight (from the root folder)

For further help you can ask for help in the comments below

@riccardoperra riccardoperra added good first issue Good for newcomers feature New feature or request labels Jul 13, 2022
@riccardoperra riccardoperra changed the title 🚀 - Vitesse theme 🚀 - Add Vitesse theme Jul 13, 2022
@riccardoperra riccardoperra moved this to Planned in CodeImage Jul 13, 2022
@riccardoperra riccardoperra added this to the M3 milestone Jul 13, 2022
@stale stale bot added the wontfix This will not be worked on label Sep 11, 2022
@stale stale bot closed this as completed Sep 19, 2022
Repository owner moved this from Planned to Done in CodeImage Sep 19, 2022
@riccardoperra riccardoperra removed the wontfix This will not be worked on label Sep 19, 2022
@riccardoperra riccardoperra reopened this Sep 19, 2022
Repository owner moved this from Done to In Progress in CodeImage Sep 19, 2022
Repository owner deleted a comment from stale bot Oct 6, 2022
@Vikki123
Copy link
Contributor

@riccardoperra Could you assign this to me ?

@Vikki123
Copy link
Contributor

Also which theme are we looking for ? Is it Vitesse light or dark ?

@riccardoperra
Copy link
Owner Author

Hey @Vikki123, yes. Both are ok. Otherwise just tell me what you prefer because I could change the title of the issue and create a new one with the remaining theme

@Vikki123
Copy link
Contributor

Vikki123 commented Oct 12, 2022

Sure .. i created a PR for dark theme. Please check it out. You can rename the title accordingly. Thanks !

@riccardoperra
Copy link
Owner Author

merged #378

Repository owner moved this from In Progress to Done in CodeImage Oct 13, 2022
@riccardoperra riccardoperra changed the title 🚀 - Add Vitesse theme 🚀 - Add Vitesse Dark theme Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers hacktoberfest
Projects
Status: Done
Development

No branches or pull requests

2 participants