Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor all Javascript code (& Ruby) #1

Open
5 tasks
ribose-jeffreylau opened this issue Jun 6, 2017 · 0 comments
Open
5 tasks

Refactor all Javascript code (& Ruby) #1

ribose-jeffreylau opened this issue Jun 6, 2017 · 0 comments
Labels
enhancement help wanted

Comments

@ribose-jeffreylau
Copy link
Contributor

  • Make sure all JS files adhere to warnings from JSHint(http://jshint.com/)

    • Put all JS code under a function scope where possible
      • Add 'use strict'; to all JS files

  • Remove all redundant files / code

  • Write tests for both JS and Ruby

    • Make sure JS specs cover as much code as possible

  • Document where it makes sense

  • Break up JS functions that are too large into more manageable chunks, etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ribose-jeffreylau