Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing corner case in cartography::getTiles #59

Closed
drikkes-jue opened this issue Feb 10, 2020 · 1 comment
Closed

missing corner case in cartography::getTiles #59

drikkes-jue opened this issue Feb 10, 2020 · 1 comment

Comments

@drikkes-jue
Copy link

If you call cartography::getTiles with x a a simple feature collection, which is not POINT, no bounding box bbx is generated. You should probably change
if (nrow(x) == 1) {
if (sf::st_is(x, "POINT")) {
to
if (nrow(x) == 1 && sf::st_is(x, "POINT")) {
@rCarto
Copy link
Member

rCarto commented Feb 10, 2020

Oh you're right, that's not good. Thanks!

@rCarto rCarto closed this as completed in 9c10028 Feb 13, 2020
dieghernan pushed a commit to dieghernan/cartography that referenced this issue Feb 14, 2020
@rCarto @dieghernan
fix riatelab#59
5c8d44d 
thanks @drikkes-jue
dieghernan pushed a commit to dieghernan/cartography that referenced this issue Feb 15, 2020
@rCarto @dieghernan
fix riatelab#59
40cf20b 
thanks @drikkes-jue
dieghernan pushed a commit to dieghernan/cartography that referenced this issue Feb 21, 2020
@rCarto @dieghernan
fix riatelab#59
7199bd1 
thanks @drikkes-jue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rCarto @drikkes-jue