Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a non-regex search #67

Open
russellbanks opened this issue May 12, 2024 · 3 comments
Open

Add a non-regex search #67

russellbanks opened this issue May 12, 2024 · 3 comments

Comments

@russellbanks
Copy link

I try to avoid using regex in my application due to the increase in binary size. It would be helpful to have a non-regex search that just highlights direct matches of the input text.

Alternatively, or alongside this, exposing a means of highlighting text (like how text selection currently is) would be helpful.

@rhysd
Copy link
Owner

rhysd commented May 15, 2024

regex::escape can be used for this.

@rhysd rhysd closed this as completed May 15, 2024
@rhysd rhysd added the question Further information is requested label May 15, 2024
@rhysd rhysd reopened this May 15, 2024
@rhysd
Copy link
Owner

rhysd commented May 15, 2024

due to the increase in binary size

How does it increase the size and what is your real-world issue due to the increase?

@rhysd rhysd removed the question Further information is requested label May 15, 2024
@rhysd
Copy link
Owner

rhysd commented May 15, 2024

Measurement on my desktop (Windows x86_64) using examples:

minimal editor
395 KiB 2078 KiB

So the point is if 2078 - 395 = 1683 KiB size increasement causes some issues or not. Personally I haven't seen a trouble due to this difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants