Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Trailing path separators are removed #10

Closed
uklotzde opened this issue Jul 1, 2022 · 3 comments
Closed

Windows: Trailing path separators are removed #10

uklotzde opened this issue Jul 1, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@uklotzde
Copy link

uklotzde commented Jul 1, 2022

to_slash() behaves differently on Windows compared to other platforms. Trailing slashes in the result are removed even if the input ends with a path separator, i.e. \. Trailing path separators are preserved for Unix-like systems.
@rhysd rhysd added the bug Something isn't working label Jul 3, 2022
@rhysd rhysd closed this as completed in a72dc60 Jul 3, 2022
@uklotzde
Copy link
Author

uklotzde commented Jul 3, 2022

Thank you!

@rhysd
Copy link
Owner

rhysd commented Jul 4, 2022

Since this is a breaking change, it will be included in next release v0.2.0.

@rhysd
Copy link
Owner

rhysd commented Jul 5, 2022

This change is included in the new release v0.2.0.

@cymruu cymruu mentioned this issue Jul 6, 2022
Merged
@davidkna davidkna mentioned this issue Aug 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhysd @uklotzde