-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker image for pre-commit #34
Conversation
I think using single binary would be better than using Docker for the following reasons:
I think, it is easiest way for tools to download executable by using the donwload script and execute the downloaded binary directly. |
OK, I changed my mind. I'll consider to prepare some Docker image for actionlint. I think it is useful for those who don't want to install dependencies like After the image is prepared, would you rebase this branch onto the latest and add the pre-commit configuration? |
e865736
to
912f429
Compare
I have pushed a Dockerfile to include the dependencies with Alpine Linux as the base image. To make the image smaller, may not be worth the ROI, IMO. I have also included a test to verify the container can build and run. Does this cover what you are looking for? P.S. FWIW, I got the Docker idea from hadolint pre-commit implementation. 😄 |
9491b44
to
f978589
Compare
Thank you for the update. Looks good. Would you wait for a few days? I'm now improving type checking in other branch. After finishing the task, let me try this branch. |
I confirmed it worked. I released the first version manually: https://hub.docker.com/repository/docker/rhysd/actionlint I'll add some commits for follow up. |
Merged 👍 Thank you for the additions. |
Is making actionlint available as a Docker image a possibility?
This PR illustrates what the implementation could look like. An account on a Docker image repository is required.