Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version parameter in Winget workflow #293

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Apr 15, 2023

The version parameter is optional and derived from the release-tag, which usually cuts the v prefix from it. Otherwise, it would lead to an incorrect PackageVersion such as microsoft/winget-pkgs#102052.

@rhysd
Copy link
Owner

rhysd commented Jun 2, 2023

Thanks. I apologize for the delay.

@rhysd rhysd merged commit a599bfc into rhysd:winget Jun 2, 2023
@sitiom sitiom deleted the patch-1 branch June 2, 2023 14:40
@rhysd
Copy link
Owner

rhysd commented Jun 15, 2023

@sitiom Winget workflow fails after this PR. Do you know the reason? https://github.com/rhysd/actionlint/actions/runs/5280674972/jobs/9553198795

@sitiom
Copy link
Contributor Author

sitiom commented Jun 15, 2023

Maybe it could be that your token is invalid, but I also see the mismatched installer URLs, which should be a Komac bug. @russellbanks

@rhysd
Copy link
Owner

rhysd commented Jun 15, 2023

I checked the token, but it was valid and not expired. I know that the same token worked before.

image

but I also see the mismatched installer URLs, which should be a Komac bug.

OK, I will make an issue tomorrow.

@sitiom
Copy link
Contributor Author

sitiom commented Jun 15, 2023

Oh, an issue is already open for it:

@rhysd
Copy link
Owner

rhysd commented Jun 15, 2023

Thanks. Then I can track the ticket.

@sitiom
Copy link
Contributor Author

sitiom commented Jun 16, 2023

Meanwhile, I have manually created a PR for the new version:

@rhysd
Copy link
Owner

rhysd commented Jun 16, 2023

Thank you. It's very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants