Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description key is not required for workflow_call secrets #174

Closed
roryabraham opened this issue Jul 9, 2022 · 4 comments
Closed

Description key is not required for workflow_call secrets #174

roryabraham opened this issue Jul 9, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@roryabraham
Copy link

The following syntax:

name: Callable Workflow

on:
  workflow_call:
    secrets:
      MY_TOKEN:

jobs:
  main:
    runs-on: ubuntu-latest
    steps:
      - run: gh pr comment --body "Test comment"
        env:
          GH_TOKEN: ${{ secrets.MY_TOKEN }}

Results in an error:

"description" is missing at "my_token" secret of workflow_call event

However, the description is optional.

@rhysd
Copy link
Owner

rhysd commented Jul 9, 2022

However, the description is optional.

Can you show a link to official document?

@roryabraham
Copy link
Author

Documentation is lacking: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onworkflow_callsecrets

In this example you can see the description key in the yml but not documented elsewhere.

@rhysd rhysd added the bug Something isn't working label Aug 17, 2022
@rhysd rhysd closed this as completed in a8df4a5 Aug 17, 2022
@roryabraham
Copy link
Author

Thanks for fixing this @rhysd! 🎉 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants