From e4b2a1b4dd81787c55fd55c737d5ba410bb07963 Mon Sep 17 00:00:00 2001 From: Navid Shaikh Date: Sat, 22 Aug 2020 02:43:46 +0530 Subject: [PATCH] Add dev notes for fetching description from source plugin (#987) Add TODO note for KafkaSource description text about desired mechanism to fetch the description from available source plugin --- pkg/kn/commands/source/human_readable_flags.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/kn/commands/source/human_readable_flags.go b/pkg/kn/commands/source/human_readable_flags.go index 91577eb11f..c95d22244e 100644 --- a/pkg/kn/commands/source/human_readable_flags.go +++ b/pkg/kn/commands/source/human_readable_flags.go @@ -31,7 +31,10 @@ var sourceTypeDescription = map[string]string{ "SinkBinding": "Binding for connecting a PodSpecable to addressable", "PingSource": "Send periodically ping events to addressable", "ContainerSource": "Generate events by Container image and send to addressable", - "KafkaSource": "Route events from Apache Kafka Server to addressable", + // TODO: source plugin could bring the description that kn could look for based on the availability + // of the plugin and fetch the description from there, for now we dont have that capability in kn + // so we're shipping harcoded short description of the KafkaSource as below + "KafkaSource": "Route events from Apache Kafka Server to addressable", } // ListTypesHandlers handles printing human readable table for `kn source list-types`