Use correct defaults sourcing for platform
#1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two issues breaking this functionality. - The functions.sh is currently sourcing only not platform specific defaults file. This works sometimes but sometimes but it might went wrong on the other than Fedora platforms. - The PLATFORM_NAME is incorrectly propagated to tests as PLATFORM variable. It was propagated from the container call this way and used correctly in the run-kstest with this name. However, all these variables are also propagated to shell scripts for given tests. There this name fails because PLATFORM_NAME is used everywhere else.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # Platform-specific defaults | ||
| if [[ -n "${PLATFORM_NAME}" ]]; then | ||
| if [[ -e "scripts/defaults-${PLATFORM_NAME}.sh" ]]; then | ||
| . "scripts/defaults-${PLATFORM_NAME}.sh" |
Check warning
Code scanning / shellcheck
SC1090 Warning
There was a problem hiding this comment.
The code is taken from elsewhere plus the issue raised here is not really an issue just it's not able to follow. I want to ignore this.
|
/test-tmt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two issues breaking this functionality.
The functions.sh is currently sourcing only not platform specific defaults file. This works sometimes but sometimes but it might went wrong on the other than Fedora platforms.
The PLATFORM_NAME is incorrectly propagated to tests as PLATFORM variable. It was propagated from the container call this way and used correctly in the run-kstest with this name. However, all these variables are also propagated to shell scripts for given tests. There this name fails because PLATFORM_NAME is used everywhere else.