Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport support for Wayland-native Anaconda live installer from Fedora #5995

Open
wants to merge 4 commits into
base: rhel-10
Choose a base branch
from

Conversation

Conan-Kudo
Copy link
Contributor

This pull request backports relevant commits to support the Wayland-native live installer setup for CentOS Stream images.

This is needed for CentOS Hyperscale and CentOS Alternative Images.

Resolves: RHEL-67390

Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm planing to backport these commits to rhel-10 branch. So let's separate these from the PR.

@Conan-Kudo
Copy link
Contributor Author

Separate what into what? This PR is entirely just a backport set.

@jkonecny12
Copy link
Member

Blocked on this: #6000

@jkonecny12 jkonecny12 added the blocked Don't merge this pull request! label Nov 18, 2024
@jkonecny12
Copy link
Member

Separate what into what? This PR is entirely just a backport set.

My point was just that this have to handled correctly on the RHEL JIRA issue which was already planned. These other commits you are backporting are changing behavior of Anaconda and these can't be taken as just a dependency of the main commit.

@Conan-Kudo
Copy link
Contributor Author

Okay, should I rebase this PR on top of yours?

@jkonecny12
Copy link
Member

jkonecny12 commented Nov 18, 2024

Okay, should I rebase this PR on top of yours?

Ideally wait until my PR is merged. Hopefully, we got these merged during this week.

As long as we have the path to the Wayland socket, we can run
Anaconda as a Wayland-native application.

(cherry picked from commit 54a7098)

Resolves: RHEL-67390
@Conan-Kudo Conan-Kudo force-pushed the rhel-10-wayland-liveinst branch from a79e675 to d70ecca Compare November 29, 2024 12:33
Setting decorated=false doesn't do what advertised, in Wayland at least.
Gtk3 will request server-side-decorations unless a titlebar is set.

We can set any widget as titlebar, because set_decorated(False) makes it
invisible. I'm using GtkDrawingArea as a low-overhead widget.

(cherry picked from commit 46f609e)

Resolves: RHEL-67390
Gdk on Wayland uses prgname as the app id.
Set it to match the desktop filename.

(cherry picked from commit 4202705)

Resolves: RHEL-67390
Co-authored-by: Jiri Konecny <[email protected]>

(cherry picked from commit 4068a9c)

Resolves: RHEL-67390
@pep8speaks
Copy link

Hello @Conan-Kudo! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 35:1: E402 module level import not at top of file

@Conan-Kudo
Copy link
Contributor Author

@jkonecny12 I've rebased this PR and cherry-picked #6018 from @aleasto too.

@jkonecny12
Copy link
Member

/kickstart-test --testtype smoke

@jkonecny12
Copy link
Member

/build-image --live

Copy link

github-actions bot commented Dec 2, 2024

Images built based on commit a9c0af9:

  • Live: failure

Download the images from the bottom of the job status page.

@jkonecny12
Copy link
Member

I forgot that rhel-10 doesn't support Live ISO builds. That failure is expected. In that case I'll just do a smoke test with standard boot.iso.

@jkonecny12
Copy link
Member

/build-image --boot.iso

Copy link

github-actions bot commented Dec 2, 2024

Images built based on commit a9c0af9:

  • boot.iso: success

Download the images from the bottom of the job status page.

@jkonecny12
Copy link
Member

/kickstart-test ui_rdp

Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done smoke testing and everything looks good to me.

@jkonecny12 jkonecny12 added ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). and removed blocked Don't merge this pull request! labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). rhel-10
Development

Successfully merging this pull request may close these issues.

4 participants