-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport support for Wayland-native Anaconda live installer from Fedora #5995
base: rhel-10
Are you sure you want to change the base?
Backport support for Wayland-native Anaconda live installer from Fedora #5995
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm planing to backport these commits to rhel-10 branch. So let's separate these from the PR.
Separate what into what? This PR is entirely just a backport set. |
Blocked on this: #6000 |
My point was just that this have to handled correctly on the RHEL JIRA issue which was already planned. These other commits you are backporting are changing behavior of Anaconda and these can't be taken as just a dependency of the main commit. |
Okay, should I rebase this PR on top of yours? |
Ideally wait until my PR is merged. Hopefully, we got these merged during this week. |
As long as we have the path to the Wayland socket, we can run Anaconda as a Wayland-native application. (cherry picked from commit 54a7098) Resolves: RHEL-67390
a79e675
to
d70ecca
Compare
Setting decorated=false doesn't do what advertised, in Wayland at least. Gtk3 will request server-side-decorations unless a titlebar is set. We can set any widget as titlebar, because set_decorated(False) makes it invisible. I'm using GtkDrawingArea as a low-overhead widget. (cherry picked from commit 46f609e) Resolves: RHEL-67390
Gdk on Wayland uses prgname as the app id. Set it to match the desktop filename. (cherry picked from commit 4202705) Resolves: RHEL-67390
Co-authored-by: Jiri Konecny <[email protected]> (cherry picked from commit 4068a9c) Resolves: RHEL-67390
Hello @Conan-Kudo! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
@jkonecny12 I've rebased this PR and cherry-picked #6018 from @aleasto too. |
/kickstart-test --testtype smoke |
/build-image --live |
Images built based on commit a9c0af9:
Download the images from the bottom of the job status page. |
I forgot that rhel-10 doesn't support Live ISO builds. That failure is expected. In that case I'll just do a smoke test with standard boot.iso. |
/build-image --boot.iso |
Images built based on commit a9c0af9:
Download the images from the bottom of the job status page. |
/kickstart-test ui_rdp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done smoke testing and everything looks good to me.
This pull request backports relevant commits to support the Wayland-native live installer setup for CentOS Stream images.
This is needed for CentOS Hyperscale and CentOS Alternative Images.
Resolves: RHEL-67390