Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conf.maldet option for report viewing in lieu of $EDITOR #290

Closed
bellwood opened this issue Jul 18, 2018 · 3 comments
Closed

conf.maldet option for report viewing in lieu of $EDITOR #290

bellwood opened this issue Jul 18, 2018 · 3 comments

Comments

@bellwood
Copy link

Would it be possible to have a setting for view_report so that we could use another binary other than the ENV $EDITOR?

It would be nice to use a pager (less, etc) for quick viewing rather than stapling up vi, vim, nano, etc

Thank you.

@rfxn
Copy link
Owner

rfxn commented Jul 30, 2018

On RHEL in /etc/sysconfig/maldet or deb based systems in /etc/default/maldet you place EDITOR=more, this would accomplish what you are after.

Let me know if a more thoughtful solution would be better and happy to consider.

Thanks

@rfxn rfxn closed this as completed Jul 30, 2018
@bellwood
Copy link
Author

Awesome, thank you very much

@samsalisbury
Copy link
Contributor

samsalisbury commented May 1, 2020

I just spent a while reading through the source to figure this out. Just curious why you would want to use $EDITOR here rather than defaulting to more or even just cat? Is it expected that the user would want to manually edit the report @rfxn?

I think it would be a big usability improvement to add a specific flag to just dump the report to stdout, e.g. --dump-report [ID], as this would be useful for generic use, where neither editors nor email are wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants