Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylint alerts corrections as part of intervention experiment #88

Closed
evidencebp opened this issue Oct 14, 2024 · 3 comments
Closed

Pylint alerts corrections as part of intervention experiment #88

evidencebp opened this issue Oct 14, 2024 · 3 comments

Comments

@evidencebp
Copy link

I'd like to conduct a software engineering experiment regarding the benefit of Pylint  alerts removal.
The experiment is described here.
In the experiments, Pylint is used with some specific alerts, files are selected for intervention and control.
After the interventions are done, one can wait and examine the results.

I'm asking for your approval for conducting the interventions in your repositories.The interventions are expected to benefit the project and will be submitted in PR for approval.

See examples of interventions in stanford-oval/storm, gabfl/vault, and coreruleset/coreruleset.

See the planed internetions.

Is it OK if I'll fix the alerts?

@evidencebp
Copy link
Author

evidencebp commented Oct 14, 2024

Specifically, in your Case I think that Pylint found few bugs.
In misc\scripts\tuptime_modify.py, line 238 is
if 'rntime' and 'slptime' and 'bootid' not in columns:

Pylint suggeted to simplify to "'bootid' not in columns" since 'rntime' and 'slptime' are considered to be True constants.
The code does not check if they are in columns, which is probably what the developer planed.
I noticed similar code in misc\scripts\tuptime_dbcheck.py, line 222

@rfmoz

@rfmoz
Copy link
Owner

rfmoz commented Dec 17, 2024

Thank you for reaching out regarding your experiment. After considering the proposal, I would prefer not to have interventions applied to the repositories at this time. I appreciate your understanding.

@rfmoz rfmoz closed this as completed Dec 17, 2024
@evidencebp
Copy link
Author

Ok.
Thnak you for notifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants