Replace rcond with rtol in pinv() call #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `pinv()` function deprecated the use of `rcond` in favour of `rtol`, and SciPy 1.14.0 removed the keyword option `rcond` completely from `pinv()`. Replaced all occurrences of `rcond` in calls to `pinv()` with `rtol`.
Need to fix workflow as well, since it still used the old-fashioned way of installing (i.e. `python setup.py install`, instead of `pip install .`)
Package `python-casacore` is not (yet) compatible with NumPy 2.0. Use latest NumPy 1.x version.
Wrong tests were called. Just invoking `pytest` should do the right thing. To be fixed in another PR.
The name of the (single) test script doesn't adhere to `pytest` standards, so it is not found. At the same time, there are a few Python files named "test*.py" that contain currently failing tests. This needs to be fixed in a different PR.
Use latest major version of `actions/setup-python`
darafferty
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pinv()function deprecated the use ofrcondin favour ofrtol, and SciPy 1.14.0 removed the keyword optionrcondcompletely frompinv(). Replaced all occurrences ofrcondin calls topinv()withrtol.