feat(modal): Port ServerIdentity (closes #112) #250
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
Not sure if still needed, but the issue was still labeled as "help-wanted" so I spruced up and finished the draft PR from before. 👍 |
|
I have read the CLA Document and I hereby sign the CLA |
Rexogamer
requested review from
insertish
and removed request for
insertish
| const [avatarId, setAvatarId] = createSignal(null); | ||
| const [uploading, setUploading] = createSignal<boolean>(); | ||
|
|
||
| async function uploadToAutumn(file) { |
There was a problem hiding this comment.
You should use File | Blob instead of not providing a type (aka. implicit any) since the FileList type is just an array of Files (See MDN's article on FileList: https://developer.mozilla.org/en-US/docs/Web/API/FileList)
| async function uploadToAutumn(file) { | |
| async function uploadToAutumn(file) { |
|
|
||
| const handleFileSelect = async (event: Event) => { | ||
| const file = event.target?.files[0]; | ||
| const json = await uploadToAutumn(file); |
There was a problem hiding this comment.
The target property in Event isn't guaranteed to be HTMLInputElement, so typescript doesn't know whether the files property actually exists or not and throws a error.
| const json = await uploadToAutumn(file); | |
| const handleFileSelect = async (event: Event & {target: HTMLInputElement}) => { |
|
|
||
| const handleFileSelect = async (event: Event) => { | ||
| const file = event.target?.files[0]; | ||
| const json = await uploadToAutumn(file); |
There was a problem hiding this comment.
| const json = await uploadToAutumn(file); | |
| const handleFileSelect = async (event: Event & {target: HTMLInputElement}) => { |
|
|
||
| const handleFileSelect = async (event: Event) => { | ||
| const file = event.target?.files[0]; | ||
| const json = await uploadToAutumn(file); |
There was a problem hiding this comment.
Typescript says that files can be null, so it's better to use the non-null assertion operator to tell it to shut up.
| const json = await uploadToAutumn(file); | |
| const file = event.target?.files![0]; |
|
|
||
| const handleFileSelect = async (event: Event) => { | ||
| const file = event.target?.files[0]; | ||
| const json = await uploadToAutumn(file); |
There was a problem hiding this comment.
| const json = await uploadToAutumn(file); | |
| const file = event.target.files![0]; |
|
PR went stale, feedback not actioned / responded to, closing out for now |
Please make sure to check the following tasks before opening and submitting a PR