Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support only WC v1 #14

Open
kathaypacific opened this issue Feb 6, 2022 · 4 comments
Open

Support only WC v1 #14

kathaypacific opened this issue Feb 6, 2022 · 4 comments
Labels
good first issue Good for newcomers

Comments

@kathaypacific
Copy link
Collaborator

kathaypacific commented Feb 6, 2022

Ubeswap desktop uses WC v2 which doesn't work with Valora, we should probably update to only use WC v1

AC

  • Valora users should be able to connect their wallet while using Revo on the desktop, as well as on their mobile device
@cajubelt
Copy link
Collaborator

cajubelt commented Feb 6, 2022

this may have been implemented in Ubeswap after we forked, probly worth checking that

@cajubelt cajubelt added the good first issue Good for newcomers label Feb 7, 2022
@kathaypacific
Copy link
Collaborator Author

hum, am i missing something? i've never been able to connect Valora to Ubeswap desktop before. every time i scan the QR, i see this error message in the app.

Image from iOS (2)

i've checked with Jean before and it seems like this behaviour is because Ube is still using use-contractkit v1. https://github.com/Ubeswap/ubeswap-interface/blob/807e07967f5c3da2012eacddaa873a90eb5883f4/package.json#L117 there is v2 available now, which might/should fix the issue.

@cajubelt
Copy link
Collaborator

cajubelt commented Feb 18, 2022

@kathaypacific that sounds right, and yes the issue also exists on Ubeswap. I think this is a bit lower priority than a couple other issues though, especially:
#32
#33

@aaronmgdr
Copy link

Recommend upgrading to from use-contract-kit to @celo/[email protected] (out this week with wc v2 support)

WCv1 will stop working march 1st

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants