Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metrics-server to MDE #4

Closed
1 task
bit-herder opened this issue Apr 29, 2020 · 4 comments
Closed
1 task

add metrics-server to MDE #4

bit-herder opened this issue Apr 29, 2020 · 4 comments

Comments

@bit-herder
Copy link
Contributor

bit-herder commented Apr 29, 2020

Background:

  • we can't run like kubectl top pods or kubectl top nodes without metrics-server

A/C:

  • we have added metrics-server template to MDE
@bit-herder
Copy link
Contributor Author

we need to do a bit of work internally to output the correct cert to use here before we get this merged up. Kubadm apparently does not use the same cert.

see issue here : kubernetes/kubeadm#1223

and here: https://github.com/kubernetes-sigs/metrics-server/blob/master/FAQ.md#how-to-run-metrics-server-securely

@jwietelmann
Copy link
Contributor

Starting to think that, given how few people set this up securely or even have their kubelets configred such that a secure install is possible, including this in MDE would add prerequisite steps that are unrealistic for the vast majority of users. Maybe if revelry really wants this, we should just drop our own HelmRelease into our own flux repos instead of having MDE do it.

@iamjoshfrank
Copy link

Based on what I've been told, and following the convo re: possible solutions, I agree. We can/should drop this from MDE and let it be a manual install if needed until the security issue(s) are resolved.

Let's assign @bit-herder to close this out or make an argument for including it, but with some changes.

@bit-herder
Copy link
Contributor Author

Thats fine for now. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants