Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markup in the Contributing docs for prop and vars tables needs to be updated #436

Open
3 tasks
blazebarsamian opened this issue Oct 2, 2019 · 0 comments
Open
3 tasks
Labels
pinned tickets that shouldnt be deleted until completed and this label is removed

Comments

@blazebarsamian
Copy link
Contributor

blazebarsamian commented Oct 2, 2019

I'm submitting a ...

  • bug report
  • feature request
  • support request

What is the current behavior?
Currently in the contributing doc the markup used for the example prop and vars tables is old. The HeadStacked portion has been updated in the table component since then and now needs to be updated in the contributing doc.

Currently written like this:

<Table.HeadStacked>
  <Table.Data>[ComponentName] Props</Table.Data>
</Table.HeadStacked>

What is the expected behavior?
HeadStacked should be written like this:

<Table.HeadStacked>
  <Table.Row>
    <Table.Header>[ComponentName] Props</Table.Header>
  </Table.Row>
</Table.HeadStacked>

For feature requests: why should the behavior change?

because it wont properly work the way its written and people are using that as a guide for writing their prop and var tables.

@blazebarsamian blazebarsamian added the pinned tickets that shouldnt be deleted until completed and this label is removed label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned tickets that shouldnt be deleted until completed and this label is removed
Projects
None yet
Development

No branches or pull requests

1 participant