Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine MediaUploader and FileInput components since theyre essentially the same. #432

Open
1 of 6 tasks
blazebarsamian opened this issue Sep 25, 2019 · 0 comments
Open
1 of 6 tasks
Labels
pinned tickets that shouldnt be deleted until completed and this label is removed

Comments

@blazebarsamian
Copy link
Contributor

blazebarsamian commented Sep 25, 2019

I'm submitting a ...

  • bug report
  • feature request
  • support request

What is the current behavior?
Theres two different components that are essentially the same thing. I think the only difference is that the Media uploader shows a preview image.

What is the expected behavior?
I think the two components should be combined with props to allow different things like showing a preview image or not.

Stylesheet Updates:

  • Combine the FileInput.scss file and MediaUploarder.scss file
  • theres a max-width and padding-bottom applied to the MediaUploaderPreview which should be vars that can be updated in the settings file.
  • MediaUploader helptext should take on the same styles as rev-InputHelpText. Which might be the problem since the mediauploader looks like its using rev-HelpText instead. so that needs to be fixed. Remove rev-MediaUploader .rev-HelpText font size.

For feature requests: why should the behavior change?
its confusing to figure out which one to use currently because theres two components in two separate places.

@blazebarsamian blazebarsamian added the pinned tickets that shouldnt be deleted until completed and this label is removed label Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned tickets that shouldnt be deleted until completed and this label is removed
Projects
None yet
Development

No branches or pull requests

1 participant