Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dismissible state to Flash component #418

Open
1 of 7 tasks
blazebarsamian opened this issue Aug 16, 2019 · 2 comments
Open
1 of 7 tasks

Add Dismissible state to Flash component #418

blazebarsamian opened this issue Aug 16, 2019 · 2 comments
Labels
enhancement pinned tickets that shouldnt be deleted until completed and this label is removed

Comments

@blazebarsamian
Copy link
Contributor

blazebarsamian commented Aug 16, 2019

Broken out from #415

I'm submitting a ...

  • bug report
  • feature request
  • support request

What is the current behavior?
Currently there is a prop thats being created in this PR (#417) for a dismissible flash message. However some work needs to be done to this component by an engineer to make sure its written properly and functions as intended.

What is the expected behavior?

  • When a dismissible flash (<Flash dismissible> is used
  • Then I can click the close button and the flash will no longer be visible.

When writing this component:

  • I would like for the close button component to be included inside the flash component itself so that when youre using it all you have to write is <Flash dismissible> Dismissible flash message </Flash and the close button will be included.
  • Harmonium doesnt have icons working so well need to use x or - for the close button for now.
    • HOWEVER, we should make it so that users could easily plug in different icons to be used as the close button (most likely using the icon component)

For feature requests: why should the behavior change?
Because we use a dismissible flash message on most projects and so it would be nice to have a component that we can pull from and use instead of reinventing the wheel every time.

@blazebarsamian blazebarsamian added enhancement pinned tickets that shouldnt be deleted until completed and this label is removed labels Aug 16, 2019
@Dacello
Copy link
Member

Dacello commented Sep 4, 2019

@blazebarsamian im gonna pick this up and just branch off of #417. Ill make a PR into that

@Dacello
Copy link
Member

Dacello commented Oct 2, 2019

@blazebarsamian FYI this was merged into #417 -- would you mind taking another look at that PR to see if it can be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement pinned tickets that shouldnt be deleted until completed and this label is removed
Projects
None yet
Development

No branches or pull requests

2 participants