Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add other ButtonGroup examples + add styles for different ButtonGroup variations #392

Open
4 of 15 tasks
blazebarsamian opened this issue Jun 14, 2019 · 1 comment
Open
4 of 15 tasks
Assignees
Labels
2 - in progress bug designy pinned tickets that shouldnt be deleted until completed and this label is removed

Comments

@blazebarsamian
Copy link
Contributor

blazebarsamian commented Jun 14, 2019

I'm submitting a ...

  • bug report
  • feature request
  • support request

What is the current behavior?
Currently we have some props that can added to ButtonGroups, however we don't have any styles written for those classes. We also only have one ButtonGroup example on the site.

What is the expected behavior?

  • When we use any of the below ButtonGroup classes, there should be styles for each one.
  • We should include a few more ButtonGroup examples on the examples page.

ButtonGroup classes that dont have any styles or need styles to be fixed:

  • .rev-ButtonGroup--small

  • .rev-ButtonGroup--large

  • .rev-ButtonGroup--primary

  • .rev-ButtonGroup--secondary

  • .rev-ButtonGroup--small

  • .rev-ButtonGroup--inverted

  • .rev-ButtonGroup--success

  • .rev-ButtonGroup--alert

  • .rev-ButtonGroup--warning

  • .rev-ButtonGroup--disabled

  • .rev-ButtonGroup--expanded

  • .rev-ButtonGroup--stackedForSmall

  • we should probably add a stackedForMediumDown prop and styles too

For feature requests: why should the behavior change?
Because we should have props that actually work. Or else not have the prop at all.

@blazebarsamian blazebarsamian added designy pinned tickets that shouldnt be deleted until completed and this label is removed bug labels Jun 14, 2019
@blazebarsamian blazebarsamian self-assigned this Jun 14, 2019
@blazebarsamian
Copy link
Contributor Author

  • secondary button groups: check to see if box-shadow vs border gets rid of the gap between buttons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - in progress bug designy pinned tickets that shouldnt be deleted until completed and this label is removed
Projects
None yet
Development

No branches or pull requests

1 participant