Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header vars: duplicate $header-font-family var; $header-color var not working #390

Open
3 tasks
blazebarsamian opened this issue May 29, 2019 · 1 comment
Open
3 tasks
Labels
bug designy pinned tickets that shouldnt be deleted until completed and this label is removed

Comments

@blazebarsamian
Copy link
Contributor

Header vars need to be revisited.

  • I'm not seeing any classes where subheader vars are applied to.
  • subheader-font-family var should be different from header font family or else it should be deleted
  • $header-color var should change the font color when updated.

I'm submitting a ...

  • bug report
  • feature request
  • support request

What is the current behavior?

  • currently there are two $header-font-family vars in the settings file. One of them needs to be changed to $subheader-font-family
  • $header-color var is only working on <h6>s.

For bugs: please provide steps to reproduce and tell us a little about your environment (e.g., what OS and version of the package you're using)

give us enough information to properly diagnose the bug

What is the expected behavior?

  • subheader vars should work when using a subheader ( check because I don't see a subheader class)
  • subheaders could possibly have different font families
  • when I update the $header-color all of my headers should change colors.

Screen Shot 2019-05-29 at 3 42 47 PM

@blazebarsamian blazebarsamian added bug designy pinned tickets that shouldnt be deleted until completed and this label is removed labels May 29, 2019
@blazebarsamian
Copy link
Contributor Author

  • Consider making the h6 color a var too so it can be changed. $h6-header-color: lighten($header-color, 20%);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug designy pinned tickets that shouldnt be deleted until completed and this label is removed
Projects
None yet
Development

No branches or pull requests

1 participant