Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumb component className inconsistency #388

Open
1 of 3 tasks
CheetoMao opened this issue May 2, 2019 · 1 comment
Open
1 of 3 tasks

Breadcrumb component className inconsistency #388

CheetoMao opened this issue May 2, 2019 · 1 comment
Labels
bug designy pinned tickets that shouldnt be deleted until completed and this label is removed

Comments

@CheetoMao
Copy link
Contributor

I'm submitting a ...

  • bug report
  • feature request
  • support request

I'm labeling as 'designy' because the issue is regarding the class name of the component, but anyone can make this fix.

What is the current behavior?
The Breadcrumbs component does not match our naming schema

For bugs: please provide steps to reproduce and tell us a little about your environment (e.g., what OS and version of the package you're using)
If you inspect the Breadcrumb component you will notice that the rev- prefix is not there

What is the expected behavior?
The rev- prevfix should be present on all components so that the class names are consistent

@CheetoMao
Copy link
Contributor Author

Note: At this point we can't just add rev- before all of the Breadcrumb classNames b/c that will break styles for any current Harmonium projects using the Breadcrumb component. A better solution would be to update the classNames to match our naming schema and then extend those styles to legacy .Breadcrumb classNames

@blazebarsamian blazebarsamian added the pinned tickets that shouldnt be deleted until completed and this label is removed label May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug designy pinned tickets that shouldnt be deleted until completed and this label is removed
Projects
None yet
Development

No branches or pull requests

2 participants