Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion & Tab hidden content via CSS #372

Open
1 task
CheetoMao opened this issue Jan 8, 2019 · 1 comment
Open
1 task

Accordion & Tab hidden content via CSS #372

CheetoMao opened this issue Jan 8, 2019 · 1 comment
Labels
pinned tickets that shouldnt be deleted until completed and this label is removed

Comments

@CheetoMao
Copy link
Contributor

I'm submitting a ...

  • bug report

What is the current behavior?
Accordions and tabs have props now that allow the content to be rendered and hidden using css. (for forms that are used across multiple tabs or accordion panes and/or animating the opening/closing of those elements) #121

Currently inline css is added to hide the inactive tabs and accordion panes. We should manage this with a className instead so that styles can be managed better and allow for animation.

The --active modifier className is getting added on all of the elements instead of just the active ones.

The vars and props tables need to be added for both of these components so that users know how to use them.

Also check className and prop name consistency.

What is the expected behavior?

  • make the classNames and props consistent
  • remove inline styles / move them to component style sheets
  • make active classes show only for active tabs or panes
  • add props and vars tables
@revelry-stalebot
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@blazebarsamian blazebarsamian added the pinned tickets that shouldnt be deleted until completed and this label is removed label May 31, 2019
@revelry-stalebot revelry-stalebot bot removed the stale label May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned tickets that shouldnt be deleted until completed and this label is removed
Projects
None yet
Development

No branches or pull requests

2 participants