Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty new_val and the fact that it's an array #14

Closed
danielmewes opened this issue May 20, 2015 · 2 comments
Closed

Handle empty new_val and the fact that it's an array #14

danielmewes opened this issue May 20, 2015 · 2 comments

Comments

@danielmewes
Copy link
Member

This was pointed out by @anthonyettinger in https://github.com/rethinkdb/rethinkdb-example-nodejs/pull/13/files#r30754551

I believe it should be result.changes[0].new_val -- but i'm not sure of the impact of only looking at [0] and sometimes, there is no new_val property if there was no change (ie: they made the call but it was with identical data as what already was in the db.

I think he is right and we need to change that.
@danielmewes danielmewes mentioned this issue May 20, 2015
Merged
@danielmewes
Copy link
Member Author

. @danyim addressed this for the angular-promise example with #17

@danielmewes
Copy link
Member Author

Also fixed for the Koa version with 5e0cff3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danielmewes