Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RecheckSeleniumAdapter#convert( Object ) performance #166

Open
beatngu13 opened this issue Feb 25, 2019 · 3 comments
Open

Improve RecheckSeleniumAdapter#convert( Object ) performance #166

beatngu13 opened this issue Feb 25, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@beatngu13
Copy link
Contributor

Conversion sometimes takes up to 5 or more seconds. It would be helpful (for surili as well) if we could somehow improve the conversion performance.

@beatngu13 beatngu13 added the enhancement New feature or request label Feb 25, 2019
@beatngu13
Copy link
Contributor Author

beatngu13 commented Mar 18, 2019

This simple test (which uses convert under the hood) shows the problem:

class GoogleIT {

	WebDriver driver;
	Recheck re;

	@BeforeEach
	void setUp() throws Exception {
		driver = new ChromeDriver();
		re = new RecheckImpl();
	}

	@Test
	void test() throws Exception {
		re.startTest();
		driver.get( "https://policies.google.com/privacy?hl=de&gl=de" );
		final long start = System.currentTimeMillis();
		re.check( driver, "german-privacy-policy" );
		final long end = System.currentTimeMillis();
		System.out.println( "check took " + TimeUnit.MILLISECONDS.toSeconds( end - start ) + " seconds" );
		re.capTest();
	}

	@AfterEach
	void tearDown() throws Exception {
		driver.quit();
		re.cap();
	}

}

This single check takes up to 14 seconds on my machine.

@beatngu13
Copy link
Contributor Author

@diba1013
Copy link

diba1013 commented Oct 1, 2019

We need to do some more investigation on where the actual performance bottleneck is.

  • No Golden Master, vs Golden Master present.
  • Retrieve data from Selenium (i.e. JavaScript)
  • Convert Performance
  • Diffing Algorithm
  • Persisting Golden Master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants