Skip to content
This repository has been archived by the owner on May 28, 2021. It is now read-only.

Proper handling of external PRs #100

Open
modulo11 opened this issue May 7, 2019 · 1 comment
Open

Proper handling of external PRs #100

modulo11 opened this issue May 7, 2019 · 1 comment
Labels
Milestone

Comments

@modulo11
Copy link
Contributor

modulo11 commented May 7, 2019

Before PR#99 rebazer crashed when trying to checkout an external PRs branch which does not exist in our origin repository. We should discuss how we want to handle this within rebazer:

  • Ignore the handling of external PRs
  • Don't try to rebase external PRs, but merge if conditions are met
  • ...
@beatngu13
Copy link
Contributor

AFAIK one gets write permissions to a PR branch from another repo, at least this was the case with e.g. the Gradle PRs in recheck.

I think it would be helpful to also handle external PRs—if it's not too much work. What was the exact error message?

@martin-v martin-v added the bug label Aug 12, 2019
@martin-v martin-v added this to the 1.0 milestone Aug 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

3 participants