You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I can open a PR updating the version, but there are probably tests that need to be run and checks that need to happen. Based on find-my-way's changelog, breaking changes include dropped support for Node.js < 12, and I don't know what the officially supported version for Restify is
The text was updated successfully, but these errors were encountered:
I ran into some assertion errors when running tests with newer versions of find-my-way. 3.0.5 passed tests, but 4.0.0 failed with four assertions, each where we are comparing printed-out route maps from find-my-way. There's new syntax we don't seem to have: └── / (GET|POST)\n, where one route is both GET and POST. I'm not 100% the route maps really are 100% the same quite yet, but am analyzing further, and cautiously optimistic: I tentatively think this is just that find-my-way has changed how it outputs/prints it's route map.
I do hope to have a PR up at some point. I've dug through the changelog & there don't seem to be any obvious significant changes. I think it may just be this route printing. Hopefully I'll have a PR up soon.
As you say, we will need to upgrade node. There are issues #1921 & pr #1923 for that.
An upgrade would also resolve #1868. Thanks for the list of other issues this would resolve @gmahomarf.
Feature Request
Use Case
I ran into an issue with
find-my-way
's routing that has since been fixed in version 5.2.0 offind-my-way
. This might also fix #1811, #1873 and #1874Example API
N/A
Are you willing and able to implement this?
I can open a PR updating the version, but there are probably tests that need to be run and checks that need to happen. Based on
find-my-way
's changelog, breaking changes include dropped support for Node.js < 12, and I don't know what the officially supported version for Restify isThe text was updated successfully, but these errors were encountered: