Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schedule hooks do not behave as expected or documented #679

Closed
jweir opened this issue Jul 8, 2019 · 1 comment · May be fixed by #792
Closed

Schedule hooks do not behave as expected or documented #679

jweir opened this issue Jul 8, 2019 · 1 comment · May be fixed by #792

Comments

@jweir
Copy link
Contributor

jweir commented Jul 8, 2019

https://github.com/resque/resque-scheduler#hooks

My reading of the before_schedule and after_schedule hooks is they should be called around when job is about to be put on the queue via enqueue_from_config.

However the {before,after}_schedule methods are only called when a job is enqueued via enqueue_at, enqueue_in, or enqueue_at_with_queue.

This could be my misreading of the documentation, in which case the documentation could be cleared up. But it seems that a callback called before_schedule would be associated with a cron schedule job.

See also #650
jweir added a commit to jweir/resque-scheduler that referenced this issue Jul 8, 2019
@jweir
enqueue(config) calls {before, after}_schedule methods
657c236 
https://github.com/resque/resque-scheduler#hooks

enqueue_at works as documented, but schedules enqueued from a config have not been calling the before/after schedule hooks.

fixes resque#679
jweir added a commit to jweir/resque-scheduler that referenced this issue Jul 8, 2019
@jweir
enqueue(config) calls {before, after}_schedule methods
ce39a0b 
https://github.com/resque/resque-scheduler#hooks

enqueue_at works as documented, but schedules enqueued from a config have not been calling the before/after schedule hooks.

fixes resque#679
@jeremy jeremy mentioned this issue Jul 9, 2019
Closed
@jeremy
Copy link
Contributor

jeremy commented Jul 9, 2019

PR with fix @ #681

@jeremy jeremy closed this as completed Jul 9, 2019
@codealchemy codealchemy mentioned this issue Oct 16, 2024
Open
codealchemy pushed a commit to codealchemy/resque-scheduler that referenced this issue Oct 16, 2024
@jweir @codealchemy
enqueue(config) calls {before, after}_schedule methods
a32d444 
https://github.com/resque/resque-scheduler#hooks

enqueue_at works as documented, but schedules enqueued from a config have not been calling the before/after schedule hooks.

fixes resque#679
@codealchemy codealchemy mentioned this issue Oct 25, 2024
Open
codealchemy pushed a commit to codealchemy/resque-scheduler that referenced this issue Oct 30, 2024
@jweir @codealchemy
enqueue(config) calls {before, after}_schedule methods
5f205ae 
https://github.com/resque/resque-scheduler#hooks

enqueue_at works as documented, but schedules enqueued from a config have not been calling the before/after schedule hooks.

fixes resque#679
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix schedule hooks when enqueuing configured job codealchemy/resque-scheduler
2 participants
@jeremy @jweir