Clean up unit test output #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use a mocked logger to remove output spam - Fix phpunit deprecation warnings
|
Well, boo 😞 The OOM error remains, and I can't reproduce that one locally. |
|
However, it looks like the OOM isn't actually an issue and it's rather failing on this line: because |
The default is phpunit 9.x and that doesn't find any tests.
Merged
danhunsaker
approved these changes
Jan 27, 2022
danhunsaker
pushed a commit
that referenced
this pull request
Jul 13, 2023
* Clean up unit test output - Use a mocked logger to remove output spam - Fix phpunit deprecation warnings * Migrate phpunit config file to newer format * Use phpunit 5.x for github actions The default is phpunit 9.x and that doesn't find any tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix all the issues scrutinizer has with the unit tests.