You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Custom patches made should be copied into the .react-email folder
Background
I manage several patches in dependencies of my email project and it cannot be removed.
everytime install the project, I should copy patches into the .react-email folder.
I made a script for that but it's not general (only works for yarn).
Proposal
I propose two direction.
Provide Hooks for .react-email Installation
for ex. preinstall-react-email, postinstall-react-email.
and expose interface for configuration.
Pros: it can support any patch format (bcuz we can make a new hook if it doesn't exists)
Cons: maybe it needs serious consideration to get a good interface
Create ad-hoc handler for each package manager
for ex. yarn 3 should copy resolutions in package.json, pnpm should copy pnpm in package.json, etc.
Pros: easy to adopt
Cons: it can be complexer if there are too many cases (currently I think there are only 3).
About Contribution
I interested in contributing on weekdays but I cannot actively contribute due to my work.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Goals
Background
I manage several patches in dependencies of my email project and it cannot be removed.
everytime install the project, I should copy patches into the .react-email folder.
I made a script for that but it's not general (only works for yarn).
Proposal
I propose two direction.
Provide Hooks for .react-email Installation
for ex. preinstall-react-email, postinstall-react-email.
and expose interface for configuration.
Pros: it can support any patch format (bcuz we can make a new hook if it doesn't exists)
Cons: maybe it needs serious consideration to get a good interface
Create ad-hoc handler for each package manager
for ex. yarn 3 should copy resolutions in package.json, pnpm should copy pnpm in package.json, etc.
Pros: easy to adopt
Cons: it can be complexer if there are too many cases (currently I think there are only 3).
About Contribution
I interested in contributing on weekdays but I cannot actively contribute due to my work.
Beta Was this translation helpful? Give feedback.
All reactions