This repository has been archived by the owner on Jun 15, 2023. It is now read-only.
Implement intelligent breaking for poly-var type expressions #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 22, 2021 18:11
Fixes #245 Given: ```rescript type currencyPoly = [#USD | #CAD | #EUR] type currencyPoly = [#USD | #CAD | #EUR] ``` we have two different layouts: In the first example the user wrote them over multiple lines. The second has them on one line. This commit implements a new strategy to print these two examples. We now look at the style of the author: did he write it over multiple lines or not? If it is on one line, keep it on one line (unless it breaks the column width). If it is written over multiple lines, force break it over multiple lines. This is also consistent with how we print variant declaration.
IwanKaramazow
force-pushed
the
intelligent-poly-variants
branch
from
0f72e8c
to
133ce1e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #245
Given:
we have two different layouts:
In the first example the user wrote them over multiple lines.
The second has them on one line.
This commit implements a new strategy to print these two examples.
We now look at the style of the author: did he write it over multiple lines or not?
If it is on one line, keep it on one line (unless it breaks the column width).
If it is written over multiple lines, force break it over multiple lines.
This is also consistent with how we print variant declaration.