Improve conversion of quoted strings from Reason. #238

IwanKaramazow · 2021-01-17T18:04:14Z

Fixes #237

The conversion from Reason to ReScript naively picks up // as comments inside quoted strings..

input:

let x = {j|https://www.apple.com|j};
let x = {|https://www.apple.com|};
let x = {js|https://www.apple.com|js};

output:

let x = j`https://www.apple.com` //www.apple.com|j};
let x = `https://www.apple.com` //www.apple.com|};
let x = `https://www.apple.com` //www.apple.com|js};

This patch fixes this behaviour and doesn't produce any extra comments

Fixes #237 The conversion from Reason to ReScript naively picks up `//` as comments inside quoted strings.. input: ```reason let x = {j|https://www.apple.com|j}; let x = {|https://www.apple.com|}; let x = {js|https://www.apple.com|js}; ``` output: ```rescript let x = j`https://www.apple.com` //www.apple.com|j}; let x = `https://www.apple.com` //www.apple.com|}; let x = `https://www.apple.com` //www.apple.com|js}; ``` This patch fixes this behaviour and doesn't produce any extra comments

Iwan added 2 commits January 17, 2021 19:03

Update CHANGELOG

294feb7

IwanKaramazow merged commit a92aa9c into master Jan 17, 2021

ryyppy deleted the quoted-string-conversion branch May 3, 2022 05:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve conversion of quoted strings from Reason. #238

Improve conversion of quoted strings from Reason. #238

IwanKaramazow commented Jan 17, 2021

Improve conversion of quoted strings from Reason. #238

Improve conversion of quoted strings from Reason. #238

Conversation

IwanKaramazow commented Jan 17, 2021