New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSX props spread with pipe is printed as invalid code #5882

Closed

cknitt opened this issue Dec 7, 2022 · 1 comment · Fixed by rescript-lang/syntax#721 or #5885

Member

cknitt commented Dec 7, 2022

<A {...(params->Obj.magic)} />

can be parsed fine, but is reprinted as

<A {...params->Obj.magic} />

which cannot be parsed anymore.

Member

mununki commented Dec 7, 2022

Also, does the fix need to be fixed in the syntax repo first?

mununki mentioned this issue

Fix parsing not atomic expression in spread props of JSX rescript-lang/syntax#721

Merged

mununki closed this as completed in rescript-lang/syntax#721

mununki mentioned this issue

Fix parsing not atomic expression in spread props of JSX #5885

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment