Skip to content
This repository has been archived by the owner on Nov 13, 2023. It is now read-only.

[Breaking Change!] [Test] Change and unify the extension of generated files. #91

Closed
cristianoc opened this issue Nov 7, 2018 · 5 comments

Comments

@cristianoc
Copy link
Collaborator

cristianoc commented Nov 7, 2018

Test a breaking change to the extension of generated files.

  • Change the extension of generated files to .regen.js and .regen.tsx.

  • The name becomes uniform across TypeScript and Flow.

  • No need for a special webpack plugin to read .re.js files instead of .re files.

  • No difference in instructions to specify the current file in bs.value with TypeScript or Flow/Untyped.

  • Make it easier to e.g. grep generated files: *.regen.*.

#90

@cristianoc
Copy link
Collaborator Author

The name regen is a placeholder.
Another possibility is e.g. .gt.

@cristianoc
Copy link
Collaborator Author

Original suggestion from #86.

@ryyppy
Copy link
Member

ryyppy commented Nov 8, 2018

🙌 I would also like to throw in .gen.js as a shorter ext suggestion

@cristianoc
Copy link
Collaborator Author

There seems to be interest in a shorter extension.
Changed the PR to .gen.tsx and .gen.js.

@cristianoc
Copy link
Collaborator Author

Merged in version 1.0.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants