Add lint for builder pattern functions and deref impls to be marked #[inline]

crates/re_arrow_store/src/store_event.rs

@@ -48,6 +48,7 @@ pub struct StoreEvent {
 impl std::ops::Deref for StoreEvent {
     type Target = StoreDiff;
 
+    #[inline]
     fn deref(&self) -> &Self::Target {
         &self.diff
     }

crates/re_renderer/src/line_strip_builder.rs

@@ -157,6 +157,7 @@ impl<'a> LineBatchBuilder<'a> {
     }
 
     /// Sets the picking object id for every element in the batch.
+    #[inline]
     pub fn picking_object_id(mut self, picking_object_id: PickingLayerObjectId) -> Self {
         self.batch_mut().picking_object_id = picking_object_id;
         self
@@ -496,6 +497,7 @@ impl<'a> LineStripBuilder<'a> {
         self
     }
 
+    #[inline]
     pub fn picking_instance_id(mut self, instance_id: PickingLayerInstanceId) -> Self {
         self.picking_instance_id = instance_id;
         self

crates/re_renderer/src/point_cloud_builder.rs

@@ -266,12 +266,14 @@ impl<'a> PointCloudBatchBuilder<'a> {
     }
 
     /// Adds (!) flags for this batch.
+    #[inline]
     pub fn flags(mut self, flags: PointCloudBatchFlags) -> Self {
         self.batch_mut().flags |= flags;
         self
     }
 
     /// Sets the picking object id for the current batch.
+    #[inline]
     pub fn picking_object_id(mut self, picking_object_id: PickingLayerObjectId) -> Self {
         self.batch_mut().picking_object_id = picking_object_id;
         self

crates/re_renderer/src/wgpu_resources/bind_group_pool.rs

@@ -30,6 +30,7 @@ pub struct GpuBindGroup {
 impl std::ops::Deref for GpuBindGroup {
     type Target = wgpu::BindGroup;
 
+    #[inline]
     fn deref(&self) -> &Self::Target {
         &self.resource.inner
     }

crates/re_renderer/src/wgpu_resources/static_resource_pool.rs

@@ -13,6 +13,7 @@ pub struct StoredResource<Res> {
 impl<Res> Deref for StoredResource<Res> {
     type Target = Res;
 
+    #[inline]
     fn deref(&self) -> &Self::Target {
         &self.resource
     }

crates/re_sdk/src/recording_stream.rs

@@ -142,6 +142,7 @@ impl RecordingStreamBuilder {
     /// If the `RERUN` environment variable is set, it will override this.
     ///
     /// Set also: [`Self::enabled`].
+    #[inline]
     pub fn default_enabled(mut self, default_enabled: bool) -> Self {
         self.default_enabled = default_enabled;
         self
@@ -152,6 +153,7 @@ impl RecordingStreamBuilder {
     /// Setting this will ignore the `RERUN` environment variable.
     ///
     /// Set also: [`Self::default_enabled`].
+    #[inline]
     pub fn enabled(mut self, enabled: bool) -> Self {
         self.enabled = Some(enabled);
         self
@@ -166,6 +168,7 @@ impl RecordingStreamBuilder {
     /// unique `RecordingId`s.
     ///
     /// The default is to use a random `RecordingId`.
+    #[inline]
     pub fn recording_id(mut self, recording_id: impl Into<String>) -> Self {
         self.store_id = Some(StoreId::from_string(
             StoreKind::Recording,
@@ -183,6 +186,7 @@ impl RecordingStreamBuilder {
     /// unique [`StoreId`]s.
     ///
     /// The default is to use a random [`StoreId`].
+    #[inline]
     pub fn store_id(mut self, store_id: StoreId) -> Self {
         self.store_id = Some(store_id);
         self
@@ -191,25 +195,29 @@ impl RecordingStreamBuilder {
     /// Specifies the configuration of the internal data batching mechanism.
     ///
     /// See [`DataTableBatcher`] & [`DataTableBatcherConfig`] for more information.
+    #[inline]
     pub fn batcher_config(mut self, config: DataTableBatcherConfig) -> Self {
         self.batcher_config = Some(config);
         self
     }
 
     #[doc(hidden)]
+    #[inline]
     pub fn store_source(mut self, store_source: StoreSource) -> Self {
         self.store_source = Some(store_source);
         self
     }
 
     #[allow(clippy::wrong_self_convention)]
     #[doc(hidden)]
+    #[inline]
     pub fn is_official_example(mut self, is_official_example: bool) -> Self {
         self.is_official_example = is_official_example;
         self
     }
 
     #[doc(hidden)]
+    #[inline]
     pub fn blueprint(mut self) -> Self {
         self.store_kind = StoreKind::Blueprint;
         self