Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rerun <file> does not work if there's already an open Rerun instance #7955

Closed
Wumpf opened this issue Oct 31, 2024 · 3 comments · Fixed by #7958
Closed

rerun <file> does not work if there's already an open Rerun instance #7955

Wumpf opened this issue Oct 31, 2024 · 3 comments · Fixed by #7958
Assignees
Labels
🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release

Comments

@Wumpf
Copy link
Member

Wumpf commented Oct 31, 2024

In repository repro:

pixi run py-build
pixi run -e py python ./examples/python/dna/dna.py
pixi run rerun some_image_file_I_had_around.png

It says it streams to an existing viewer, but nothing ever shows.
On 0.19 the image opens in new rerun instance, also not what I expected to happen, but not as broken.

@Wumpf Wumpf added 🪳 bug Something isn't working 🦟 regression A thing that used to work in an earlier release 📺 re_viewer affects re_viewer itself labels Oct 31, 2024
@Wumpf Wumpf added this to the 0.20 - Maps, H.264 milestone Oct 31, 2024
@teh-cmc
Copy link
Member

teh-cmc commented Oct 31, 2024

I think I remember this working properly back when we merged #6951, hmm... 🤔

Lemme try this

@teh-cmc
Copy link
Member

teh-cmc commented Oct 31, 2024

Yup, it sure is broken now. Digging.

@teh-cmc teh-cmc self-assigned this Oct 31, 2024
@teh-cmc
Copy link
Member

teh-cmc commented Oct 31, 2024

Welp, after a long dig into the git history, the only explanation I can come to is that I severely hallucinated when I merged this PR: the code cannot work because... well the code just isn't there. Literally, there is no code:
https://github.com/rerun-io/rerun/pull/6951/files#diff-2a04e2af4408b757cb5b308ac05290c50f5f04128f6d8072025f746849ebccf0R788-R790

} else if is_another_viewer_running {
    re_log::info!("Another viewer is already running, streaming data to it.");
    Ok(())
}

There's a print saying we're forwarding the data, but... we don't.

I'm certain I tested this and was happy with the results though :|
There's no such code anywhere in the history so that doesn't look like a botched rebase either..?! I have no idea what on earth is going on.

Well, whatever I guess, I'll just implement some forwarding logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants