Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web viewer canvas is tiny #6507

Closed
emilk opened this issue Jun 5, 2024 · 0 comments
Closed

Web viewer canvas is tiny #6507

emilk opened this issue Jun 5, 2024 · 0 comments
Labels
🪳 bug Something isn't working 🕸️ web regarding running the viewer in a browser
Milestone

Comments

@emilk
Copy link
Member

emilk commented Jun 5, 2024

Repro: pixi run rerun-web and then look at it in Firefox or Brave/Chromium:

image

This is maybe related to:

@emilk emilk added 🪳 bug Something isn't working 🕸️ web regarding running the viewer in a browser labels Jun 5, 2024
@emilk emilk added this to the 0.17 milestone Jun 5, 2024
@emilk emilk changed the title Web viewer is tiny Web viewer canvas is tiny Jun 5, 2024
jprochazk added a commit that referenced this issue Jun 6, 2024
### What

The canvas size was the default of 300x150 because we didn't update the
CSS in `index.html` after
- emilk/egui#4536

Closes
- #6507

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6511?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6511?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6511)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
@emilk emilk reopened this Jun 7, 2024
@emilk emilk closed this as completed Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

No branches or pull requests

2 participants