Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of rerun::CollectionAdapter on archetype mono component fields #4258

Open
Tracked by #4260
Wumpf opened this issue Nov 17, 2023 · 0 comments
Open
Tracked by #4260
Labels
🌊 C++ API C/C++ API specific enhancement New feature or request
Milestone

Comments

@Wumpf
Copy link
Member

Wumpf commented Nov 17, 2023

Archetypes consist of rerun::Collection<ComponentType> for every component that is not a so called "mono component". Common examples for this are image, transform and mesh.

This means that you can write an adapter that allows you to log your points, making rerun::Points3D(myPoints) work for arbitrary types, but the same can't be achieved with rerun::Image(myImage) since there is no way to enhance this with an adapter.

From a performance stand point we already solved the main concerns: Buffers within image and mesh are rerun::Collection and thus they can be adapted and/or borrow arbitrary data.
For ergonomics this is still problematic though!

@Wumpf Wumpf added enhancement New feature or request 🌊 C++ API C/C++ API specific labels Nov 17, 2023
@Wumpf Wumpf added this to the Triage milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌊 C++ API C/C++ API specific enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant