don't require ninja on roundtrip tests

rerun-io · Nov 20, 2023 · 2c5135d · 2c5135d
1 parent 2653399
commit 2c5135d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/docs/code-examples/roundtrips.py b/docs/code-examples/roundtrips.py
@@ -121,11 +121,10 @@ def main() -> None:
         build_type = "Debug"
         if args.release:
             build_type = "Release"
+        # TODO(andreas): We should pixi for the prepare so we can ensure we have build tooling ready
         configure_args = [
             "cmake",
             "-G",
-            "Ninja",
-            "-B",
             cpp_build_dir,
             f"-DCMAKE_BUILD_TYPE={build_type}",
             "-DCMAKE_COMPILE_WARNING_AS_ERROR=ON",

diff --git a/tests/roundtrips.py b/tests/roundtrips.py
@@ -86,10 +86,9 @@ def main() -> None:
         build_type = "Debug"
         if args.release:
             build_type = "Release"
+        # TODO(andreas): We should pixi for the prepare so we can ensure we have build tooling ready
         configure_args = [
             "cmake",
-            "-G",
-            "Ninja",
             "-B",
             cpp_build_dir,
             f"-DCMAKE_BUILD_TYPE={build_type}",