Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve minified version #7

Closed
AlicanC opened this issue Feb 18, 2015 · 4 comments
Closed

Serve minified version #7

AlicanC opened this issue Feb 18, 2015 · 4 comments

Comments

@AlicanC
Copy link

AlicanC commented Feb 18, 2015

Most Bower packages come with a minified version of libraries and a sourcemap for debugging purposes.

We could minify it in our own build processes, but minifiers can break libraries so they are better minified and tested by their authors.

@AlicanC
Copy link
Author

AlicanC commented Feb 18, 2015

I should also note that older requests for this (#3 #5 #6) do not mention the possible breakage. This is a problem with Jade and it pushes users of these complex libraries to look for officially minified and tested files:
pugjs/pug#298

Also one of the reasons given why this won't happen is that the best practice is to use "r.js". The minified version being available for download on the webpage conflicts with this reasoning.

@jrburke
Copy link
Member

jrburke commented Feb 18, 2015

I just do not believe this is the right way forward for delivering packages of code with both a non-minified and minified version in the package. I do not see this as how JS code in general will be delivered in the future once modules become more widespread for the front end. If this is needed, then someone else who really wants it can create a separate repo for those purposes.

@jrburke jrburke closed this as completed Feb 18, 2015
@AlicanC
Copy link
Author

AlicanC commented Feb 18, 2015

Can you at least update the documentation with information on how to minify it? A link to the script you use to generate the minified version on the webpage would suffice. Then at least we can have the confidence of using the same minifier and options that you use with it. Even if minification of the library doesn't require anything special, it would be nice to know that it doesn't.

@cdll
Copy link

cdll commented Jan 21, 2016

oh i got it~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants