Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SourceAddressAdapter with certain port should be stricter with pool size and blocking? #330

Open
n1ngu opened this issue Jul 25, 2022 · 0 comments
Open

SourceAddressAdapter with certain port should be stricter with pool size and blocking? #330

n1ngu opened this issue Jul 25, 2022 · 0 comments

Comments

@n1ngu
Copy link

n1ngu commented Jul 25, 2022

As far as I understand, if SourceAddressAdapter is used with an (IP, PORT) tuple and the port is other than 0, there is no way this adapter can work without passing

pool_connections=1,
pool_maxsize=1,
pool_block=True,

to the underlying HTTPAdapter.

Shouldn't this either

  • be forced by the implementation
  • raise a warning if this exact values are not specified by the user
  • write more documentation about it

?
@n1ngu n1ngu changed the title SourceAddressAdapter with certain should be stricter with pool size and blocking? SourceAddressAdapter with certain port should be stricter with pool size and blocking? Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@n1ngu