Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network issues with node 20+ #3458

Open
simllll opened this issue Jul 17, 2023 · 2 comments
Open

network issues with node 20+ #3458

simllll opened this issue Jul 17, 2023 · 2 comments

Comments

@simllll
Copy link

simllll commented Jul 17, 2023 •
edited
Loading

Summary

we have major issues with the request library with node 20,
I know this library is not maintained anymore, but would like to gather some feedback / inputs
if there are any backgrounds to this or possible workarounds.

the strange thing is, we cannot reproduce this issue locally or even on the instance that causes troubles when running as a local script.

what is happening? requests are failing with strange results:
1.) either the requst ist not accepted (e.g. by aws S3), it returns with:

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<HTML><HEAD><META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">
<TITLE>ERROR: The request could not be satisfied</TITLE>
</HEAD><BODY>

2.) hubspot (v2) api uses request behind the scene as well, and there we suddenly get errors with "302 Found" and it seems either the redirect is not followed anymore, or some wrong request causing the redirect in first place.

Expected Behavior

not sure what's causing this, we are currently looking into
--no-network-family-autoselection
but it should work / behave like it did before.

Current Behavior

requests are failing, but with in a non reproduceable way.

Possible Solution

not sure

Your Environment

node v20.4.0 on linux (arm64)

possible related:
@simllll simllll changed the title node 20 issues network issues with node 20+ Jul 17, 2023
@simllll
Copy link
Author

simllll commented Jul 17, 2023

Update: it's related to Sentry. If sentry is set up on arm64, it starts behaving diffrently

@simllll simllll mentioned this issue Jul 17, 2023
Closed
3 tasks
@Zhangdroid
Copy link

I think the root cause is on nodejs side, see: nodejs/node#48921

@Zhangdroid Zhangdroid mentioned this issue Jul 26, 2023
Closed
debadree25 pushed a commit to nodejs/node that referenced this issue Jul 29, 2023
@Zhangdroid @debadree25
url: fix isURL detection by checking path
d7ed3a4 
Fixes: #48921
PR-URL: #48928
Fixes: getsentry/sentry-javascript#8552
Fixes: request/request#3458
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
@dmcr dmcr mentioned this issue Aug 4, 2023
Closed
pluris pushed a commit to pluris/node that referenced this issue Aug 6, 2023
@Zhangdroid
url: fix isURL detection by checking path
3ebfc74 
Fixes: nodejs#48921
PR-URL: nodejs#48928
Fixes: getsentry/sentry-javascript#8552
Fixes: request/request#3458
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
pluris pushed a commit to pluris/node that referenced this issue Aug 7, 2023
@Zhangdroid
url: fix isURL detection by checking path
cce6a1d 
Fixes: nodejs#48921
PR-URL: nodejs#48928
Fixes: getsentry/sentry-javascript#8552
Fixes: request/request#3458
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this issue Aug 14, 2023
@Zhangdroid @Ceres6
url: fix isURL detection by checking path
14c7b51 
Fixes: nodejs#48921
PR-URL: nodejs#48928
Fixes: getsentry/sentry-javascript#8552
Fixes: request/request#3458
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this issue Aug 14, 2023
@Zhangdroid @Ceres6
url: fix isURL detection by checking path
69c1b8d 
Fixes: nodejs#48921
PR-URL: nodejs#48928
Fixes: getsentry/sentry-javascript#8552
Fixes: request/request#3458
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this issue Aug 14, 2023
@Zhangdroid @UlisesGascon
url: fix isURL detection by checking path
5d2a08a 
Fixes: nodejs#48921
PR-URL: nodejs#48928
Fixes: getsentry/sentry-javascript#8552
Fixes: request/request#3458
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
RafaelGSS pushed a commit to nodejs/node that referenced this issue Aug 15, 2023
@Zhangdroid @RafaelGSS
url: fix isURL detection by checking path
e1a73d8 
Fixes: #48921
PR-URL: #48928
Fixes: getsentry/sentry-javascript#8552
Fixes: request/request#3458
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
RafaelGSS pushed a commit to RafaelGSS/node that referenced this issue Aug 15, 2023
@Zhangdroid @RafaelGSS
url: fix isURL detection by checking path
2489588 
Fixes: nodejs#48921
PR-URL: nodejs#48928
Fixes: getsentry/sentry-javascript#8552
Fixes: request/request#3458
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
RafaelGSS pushed a commit to nodejs/node that referenced this issue Aug 17, 2023
@Zhangdroid @RafaelGSS
url: fix isURL detection by checking path
60d6141 
Fixes: #48921
PR-URL: #48928
Fixes: getsentry/sentry-javascript#8552
Fixes: request/request#3458
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this issue Oct 9, 2023
@Zhangdroid @aduh95
url: fix isURL detection by checking path
e0891a8 
Fixes: nodejs#48921
PR-URL: nodejs#48928
Fixes: getsentry/sentry-javascript#8552
Fixes: request/request#3458
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
targos pushed a commit to nodejs/node that referenced this issue Nov 27, 2023
@Zhangdroid @targos
url: fix isURL detection by checking path
7fc15b6 
Fixes: #48921
PR-URL: #48928
Backport-PR-URL: #50105
Fixes: getsentry/sentry-javascript#8552
Fixes: request/request#3458
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
@sercher
url: fix isURL detection by checking path
52a3489 
Fixes: nodejs/node#48921
PR-URL: nodejs/node#48928
Backport-PR-URL: nodejs/node#50105
Fixes: getsentry/sentry-javascript#8552
Fixes: request/request#3458
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
@sercher
url: fix isURL detection by checking path
39ddf70 
Fixes: nodejs/node#48921
PR-URL: nodejs/node#48928
Backport-PR-URL: nodejs/node#50105
Fixes: getsentry/sentry-javascript#8552
Fixes: request/request#3458
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

url: fix isURL detection by checking path
2 participants
@simllll @Zhangdroid